Skip to content

gh-148067: Fix typo in asyncio event loop docs: 'signals' -> 'signal'#148073

Merged
kumaraditya303 merged 2 commits intopython:mainfrom
Herrtian:fix-asyncio-signal-typo
Apr 4, 2026
Merged

gh-148067: Fix typo in asyncio event loop docs: 'signals' -> 'signal'#148073
kumaraditya303 merged 2 commits intopython:mainfrom
Herrtian:fix-asyncio-signal-typo

Conversation

@Herrtian
Copy link
Copy Markdown
Contributor

@Herrtian Herrtian commented Apr 4, 2026 •
edited by bedevere-app bot
Loading

Fix a small typo in the asyncio event loop documentation.

The "Set signal handlers for SIGINT and SIGTERM" example section says:

(This signals example only works on Unix.)

It should be signal (referring to the signal module), not signals.

Closes #148067

📚 Documentation preview 📚: https://cpython-previews--148073.org.readthedocs.build/

@Herrtian
Fix typo in asyncio event loop docs: 'signals' -> 'signal'
cc3cbe5 
The example section references the `signal` module, not `signals`.

Closes python#148067
@python-cla-bot
Copy link
Copy Markdown

python-cla-bot bot commented Apr 4, 2026 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Apr 4, 2026
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Apr 4, 2026
@Herrtian Herrtian changed the title Fix typo in asyncio event loop docs: 'signals' -> 'signal' gh-148067: Fix typo in asyncio event loop docs: 'signals' -> 'signal' Apr 4, 2026
@bedevere-app bedevere-app bot mentioned this pull request Apr 4, 2026
Closed
@Herrtian
Copy link
Copy Markdown
Contributor Author

Herrtian commented Apr 4, 2026

I have signed the CLA at https://www.python.org/psf/contrib/contrib-form/ using my GitHub account (Herrtian). Please re-check.

@StanFromIreland
Copy link
Copy Markdown
Member

StanFromIreland commented Apr 4, 2026

I'm afraid you'll also have to sign it through the button above, the form is "ONLY for signing Contributor Agreements on behalf of organizations."

@Herrtian
Copy link
Copy Markdown
Contributor Author

Herrtian commented Apr 4, 2026

I'm afraid you'll also have to sign it through the button above, the form is "ONLY for signing Contributor Agreements on behalf of organizations."

Done it!

@kumaraditya303 kumaraditya303 merged commit 611d606 into python:main Apr 4, 2026
34 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Apr 4, 2026
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
Merged
@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Apr 8, 2026
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Apr 8, 2026

Thanks @Herrtian for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Apr 8, 2026

Thanks @Herrtian for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 8, 2026

GH-148245 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 8, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 8, 2026

GH-148246 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Apr 8, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 8, 2026
@Herrtian @miss-islington
pythongh-148067: Fix typo in asyncio event loop docs: 'signals' -> 's…
248da4c 
…ignal' (pythonGH-148073)

(cherry picked from commit 611d606)

Co-authored-by: TT <70463940+Herrtian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

small typo in asyncio-eventloop.html

4 participants

@Herrtian @StanFromIreland @kumaraditya303 @hugovk